Update iOS library to latest version 3.15 and optout method (iOS) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 21, 2016 16:18
|
I only implemented the output for iOS, but I'm assuming it would be quite easy to set it up for Android. |
|
@YannickGagnon shouldn't it be updated https://github.com/appfeel/analytics-google/blob/master/plugin.xml#L66 as well? |
|
@miqmago, updated how? The file itself is updated but the reference isn't, unless I'm missing something |
|
Oh no, it's ok, my fault as I haven't seen that it was already updated the library file itself... The problem I see with this PR is that you introduced a new method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.